Contents x
    GitHub Pull Request Feature
    • 16 Dec 2022
    • Print
    • Dark
      Light
    • PDF
    Contents

    GitHub Pull Request Feature

    • Updated on 16 Dec 2022
    • Print
    • Dark
      Light
    • PDF
    Article Summary

    Note

    This is a machine-translated version of the original Japanese article.
    Please understand that some of the information contained on this page may be inaccurate.

    summary

    The GitHub Pull Request review feature works with GitHub to create pull requests for changes to forwarding settings.
    You can use it to review and review changes.
    This page describes the settings and usage examples of the GitHub pull request review function.

    supplement

    The GitHub pull request review feature is a paid option.
    To do so, please contact your sales representative or Customer Success.

    Advance preparation and usage

    Since it is an optional feature, the following two options must be enabled.

    • Git repository linkage function
    • GitHub pull request review feature

    Configuring Git repository integration

    You need to set up the GitHub repository you want to use in advance.
    For details, please refer to About Git repository integration.

    Configuring a GitHub Personal Access Token

    For each trocco user who creates a pull request, issue and register a GitHub account and access token.

    1. From the settings at the top right of the screen, click External Linked Services.
      image.png

    2. From the External Integration Service page, enter your GitHub access token.
      image.png

    Issuing an access token for GitHub

    It can be issued from the New personal access token (classic).
    The following is an example of issuing a GitHub access token.
    image.png

    1. On the confirmation and application screen of Edit Transfer Settings STEP3, Pull Request Creation will be displayed.
      image

    Flow from creating a pull request to saving forwarding settings

    If you use the Teams feature

    If you are using the team function, in order to create a pull request, you need to select the resource group associated with the Git repository you are linking in "Resource Group" in Edit Transfer Settings STEP1.

    About saving transfer settings

    If you're using the GitHub pull request review feature, you can still save your forwarding settings without going through the process of creating a pull request.
    Please be careful when designing a business process based on the assumption of creating and reviewing pull requests before creating or changing new forwarding settings.

    1. On the confirmation and application screen of Edit Transfer Settings STEP3, click Create Pull Request.

    2. Enter a Pull Request title and click Create Pull Request.
      image

    3. From the draft confirmation screen, click Confirm Pull Request.
      The Pull requests page on GitHub opens.
      image

    4. As a result of the review, if there are no problems, we will merge them.
      image

    5. Open the trocco draft confirmation screen again and click Save. Changes to forwarding settings are reflected.

    Reflecting changes to forwarding settings

    When you merge a pull request on GitHub, changes to the forwarding settings on trocco will not be reflected.
    Be sure to click Save on Trocco for the changes to take effect.

    If you can't save your forwarding settings

    If neither merge nor close a pull request has been made, you cannot click Save.
    Merge or close on GitHub first.
    image.png

    Supplement

    When you want to update a pull request

    After creating a pull request, there are cases where you can change the forwarding settings again.
    At this time, you can also update the pull request according to your changes.

    1. From the draft confirmation screen, click Resume editing from draft.
      image

    2. Edit the forwarding settings in STEP1 and STEP2.

    3. On the confirmation / application screen of Draft Edit STEP3 of Transfer Settings, click Pull Request Update / Save Draft.
      image

    4. Click Update Remote Branch.
      Click to make additional commits to the remote branch and follow the changes to the pull request.
      image.png

    When you want to update the transfer settings without applying a pull request

    When you create a pull request, the Save button is disabled until you merge or close it, and you won't be able to reflect any changes in the transfer settings.
    This section describes how to enable the Save Pull Request button again without merging.

    1. Open the target pull request page.
      You can also open it by clicking Confirm Pull Request from the draft confirmation screen.
      image

    2. Close the pull request.
      image

    3. Delete the remote branch.
      image

    Delete a remote branch associated with a pull request

    Be sure to delete the remote branch.

    When step 2 above is completed, the save button on the trocco draft confirmation screen will be enabled.
    You will not be able to create a pull request again until the remote branch associated with the pull request is deleted.

    Was this article helpful?
    What's Next